Expand Pester coverage across install, tweaks, and UI workflows (#4792)

* Harden Pester CI and discard runspace return values * Add prioritized test backlog * Add WinUtil action logging * Add config integrity tests * Add XAML control wiring tests * Add registry and service helper tests * Add package manager tests * Add runspace behavior tests * Add tweak orchestration tests * Add install workflow tests * Add update profile tests * Add AppX removal tests * Log package installer output * Add UI state helper tests * Pin Pester test runner version * Expand Win11 Creator tests * Add preferences and theme tests * Add search filter tests * Add compile contract tests * Use single WinUtil session log * Remove installer output logging helper * Handle locked WinUtil transcript log * Avoid appending to active transcript log * Log install uninstall package identities
2026-08-09 09:31:15 +10:00 · 2026-07-01 21:49:15 -05:00
parent c3b4f85fce
commit 2cb20893fc
44 changed files with 4586 additions and 36 deletions
@@ -0,0 +1,157 @@
+#===========================================================================
+# Tests - System Helper Functions
+#===========================================================================
+
+$repoRoot = (Resolve-Path (Join-Path $PSScriptRoot "..")).Path
+
+BeforeAll {
+    $script:repoRoot = (Resolve-Path (Join-Path $PSScriptRoot "..")).Path
+    . (Join-Path $script:repoRoot "functions\private\Set-WinUtilRegistry.ps1")
+    . (Join-Path $script:repoRoot "functions\private\Set-WinUtilService.ps1")
+
+    function Write-WinUtilLog { }
+}
+
+Describe "Set-WinUtilRegistry" {
+    BeforeEach {
+        $script:testPathResults = @{}
+
+        Mock Write-Host { }
+        Mock Write-Warning { }
+        Mock Write-WinUtilLog { }
+        Mock Test-Path {
+            param([string]$Path)
+
+            if ($script:testPathResults.ContainsKey($Path)) {
+                return $script:testPathResults[$Path]
+            }
+
+            throw "Unexpected Test-Path call: $Path"
+        }
+        Mock New-PSDrive { }
+        Mock New-Item { }
+        Mock Set-ItemProperty { }
+        Mock Remove-ItemProperty { }
+    }
+
+    It "creates a missing registry path before setting a value" {
+        $registryPath = "HKCU:\Software\WinUtilTest"
+        $script:testPathResults["HKU:\"] = $true
+        $script:testPathResults[$registryPath] = $false
+
+        Set-WinUtilRegistry -Path $registryPath -Name "Enabled" -Type "DWord" -Value "1"
+
+        Should -Invoke -CommandName New-PSDrive -Times 0 -Exactly
+        Should -Invoke -CommandName New-Item -Times 1 -Exactly -ParameterFilter {
+            $Path -eq $registryPath -and $Force -eq $true -and $ErrorAction -eq "Stop"
+        }
+        Should -Invoke -CommandName Set-ItemProperty -Times 1 -Exactly -ParameterFilter {
+            $Path -eq $registryPath -and
+                $Name -eq "Enabled" -and
+                $Type -eq "DWord" -and
+                $Value -eq "1" -and
+                $Force -eq $true -and
+                $ErrorAction -eq "Stop"
+        }
+        Should -Invoke -CommandName Remove-ItemProperty -Times 0 -Exactly
+    }
+
+    It "creates the HKU PSDrive when it is missing" {
+        $registryPath = "HKCU:\Software\WinUtilTest"
+        $script:testPathResults["HKU:\"] = $false
+        $script:testPathResults[$registryPath] = $true
+
+        Set-WinUtilRegistry -Path $registryPath -Name "Enabled" -Type "DWord" -Value "1"
+
+        Should -Invoke -CommandName New-PSDrive -Times 1 -Exactly -ParameterFilter {
+            $PSProvider -eq "Registry" -and
+                $Name -eq "HKU" -and
+                $Root -eq "HKEY_USERS"
+        }
+        Should -Invoke -CommandName New-Item -Times 0 -Exactly
+        Should -Invoke -CommandName Set-ItemProperty -Times 1 -Exactly -ParameterFilter {
+            $Path -eq $registryPath -and $Name -eq "Enabled" -and $Type -eq "DWord" -and $Value -eq "1"
+        }
+    }
+
+    It "removes a registry value when requested" {
+        $registryPath = "HKLM:\Software\WinUtilTest"
+        $script:testPathResults["HKU:\"] = $true
+        $script:testPathResults[$registryPath] = $true
+
+        Set-WinUtilRegistry -Path $registryPath -Name "ObsoleteValue" -Type "String" -Value "<RemoveEntry>"
+
+        Should -Invoke -CommandName Set-ItemProperty -Times 0 -Exactly
+        Should -Invoke -CommandName Remove-ItemProperty -Times 1 -Exactly -ParameterFilter {
+            $Path -eq $registryPath -and
+                $Name -eq "ObsoleteValue" -and
+                $Force -eq $true -and
+                $ErrorAction -eq "Stop"
+        }
+    }
+}
+
+Describe "Set-WinUtilService" {
+    BeforeEach {
+        Mock Write-Host { }
+        Mock Write-Warning { }
+        Mock Write-WinUtilLog { }
+        Mock Get-Service { }
+        Mock Set-Service { }
+    }
+
+    It "sets the startup type for an existing service" {
+        Mock Get-Service {
+            [pscustomobject]@{
+                Name = "DiagTrack"
+                StartType = "Automatic"
+            }
+        } -ParameterFilter { $Name -eq "DiagTrack" -and $ErrorAction -eq "Stop" }
+
+        Set-WinUtilService -Name "DiagTrack" -StartupType "Disabled"
+
+        Should -Invoke -CommandName Get-Service -Times 1 -Exactly -ParameterFilter {
+            $Name -eq "DiagTrack" -and $ErrorAction -eq "Stop"
+        }
+        Should -Invoke -CommandName Set-Service -Times 1 -Exactly -ParameterFilter {
+            $StartupType -eq "Disabled" -and $ErrorAction -eq "Stop"
+        }
+    }
+
+    It "does not change a service that already has the requested startup type" {
+        Mock Get-Service {
+            [pscustomobject]@{
+                Name = "DiagTrack"
+                StartType = "Disabled"
+            }
+        } -ParameterFilter { $Name -eq "DiagTrack" -and $ErrorAction -eq "Stop" }
+
+        Set-WinUtilService -Name "DiagTrack" -StartupType "Disabled"
+
+        Should -Invoke -CommandName Get-Service -Times 1 -Exactly
+        Should -Invoke -CommandName Set-Service -Times 0 -Exactly
+    }
+
+    It "does not call Set-Service when the service is missing" {
+        Mock Get-Service {
+            $exception = [Microsoft.PowerShell.Commands.ServiceCommandException]::new("Cannot find any service with service name '$Name'.")
+            $errorRecord = [System.Management.Automation.ErrorRecord]::new(
+                $exception,
+                "NoServiceFoundForGivenName,Microsoft.PowerShell.Commands.GetServiceCommand",
+                [System.Management.Automation.ErrorCategory]::ObjectNotFound,
+                $Name
+            )
+            throw $errorRecord
+        } -ParameterFilter { $Name -eq "MissingService" -and $ErrorAction -eq "Stop" }
+
+        Set-WinUtilService -Name "MissingService" -StartupType "Disabled"
+
+        Should -Invoke -CommandName Get-Service -Times 1 -Exactly -ParameterFilter {
+            $Name -eq "MissingService" -and $ErrorAction -eq "Stop"
+        }
+        Should -Invoke -CommandName Set-Service -Times 0 -Exactly
+        Should -Invoke -CommandName Write-Warning -Times 1 -Exactly -ParameterFilter {
+            $Message -eq "Service MissingService was not found."
+        }
+    }
+}