Improve UI startup after runspace overhaul (#5056)

* perf: keep UI startup responsive

* test: make favicon checks runner-safe

* fix: qualify favicon visibility state

* test: isolate favicon visibility fixture

* fix: enforce total favicon deadline

* fix: address favicon review feedback

* fix: recognize disabled SSH firewall rule

* perf: restore favicon download throughput

* docs: allow public PR review uploads

* perf: restore overlapping favicon loading
This commit is contained in:
Chris Titus
2026-09-07 11:33:39 -05:00
committed by GitHub
parent 283b9954f1
commit a0d3c719a6
11 changed files with 97 additions and 9 deletions
+13 -1
View File
@@ -124,7 +124,7 @@ Describe "Invoke-WinUtilSSHServer" {
It "enables an existing disabled firewall rule instead of recreating it" {
New-SshdConfig -AdministratorsBlock $script:defaultAdministratorsBlock | Out-Null
Mock Get-NetFirewallRule { [pscustomobject]@{ Enabled = $false } }
Mock Get-NetFirewallRule { [pscustomobject]@{ Enabled = 2 } }
Mock Set-NetFirewallRule { }
Mock New-NetFirewallRule { }
@@ -136,6 +136,18 @@ Describe "Invoke-WinUtilSSHServer" {
Should -Invoke New-NetFirewallRule -Times 0 -Exactly
}
It "leaves an existing enabled firewall rule unchanged" {
New-SshdConfig -AdministratorsBlock $script:defaultAdministratorsBlock | Out-Null
Mock Get-NetFirewallRule { [pscustomobject]@{ Enabled = 1 } }
Mock Set-NetFirewallRule { }
Mock New-NetFirewallRule { }
Invoke-WinUtilSSHServer
Should -Invoke Set-NetFirewallRule -Times 0 -Exactly
Should -Invoke New-NetFirewallRule -Times 0 -Exactly
}
It "leaves an sshd_config without an administrators block alone" {
$original = New-SshdConfig -AdministratorsBlock ""
Set-ProfileKeyFile -Keys @("ssh-ed25519 AAAAnotanadminkey laptop")