mirror of
https://github.com/ChrisTitusTech/winutil.git
synced 2026-08-09 17:41:14 +10:00
* fix: repair popup install binding, dialog titles, presets switch, radio groups, JSON, tests - Invoke-WPFInstall: add param block so the right-click app popup binds -PackagesToInstall. It previously dropped the argument into $args and installed the whole selected list instead of the clicked app (or warned that nothing was selected). - Replace undefined $AppTitle with "WinUtil" in Install/UnInstall warning boxes, matching the XAML window title and sibling dialogs. - tweaks.json: remove stray nested "link" inside the WPFToggleScrollbars registry entry (dead property; registry entries expose only the six consumed fields). - Invoke-WPFPresets: fix dead switch cases to the wildcard-pattern convention so selectedFeatures/selectedToggles clear correctly. - Invoke-WPFUIElements: store the group StackPanel in radioButtonGroups so grouped radio buttons share one container (else branch was unreachable). - sanity.Tests.ps1: pass the Windows PowerShell parser script via -EncodedCommand; -Command string marshaling corrupted backticks/quotes and produced false parse failures. - install-workflow.Tests.ps1: remove the AppTitle workaround and update title assertions to "WinUtil"; drop orphaned cleanup lines. - Add CHANGES.md with technical and plain-language explanations. Verified: each bug reproduced against HEAD, fixes demonstrated to change behavior, full Pester suite 471/471. * Delete * test: cover the explicit popup install parameter path Add a regression test invoking Invoke-WPFInstall -PackagesToInstall with a package different from the default sync.selectedApps selection and assert the runspace receives the explicit object, mirroring the Initialize-WPFUI popup call shape. Existing default-path coverage is unchanged.
128 lines
6.4 KiB
PowerShell
128 lines
6.4 KiB
PowerShell
function Invoke-WPFUnInstall {
|
|
param(
|
|
[Parameter(Mandatory=$false)]
|
|
[PSObject[]]$PackagesToUninstall = $($sync.selectedApps | Foreach-Object { $sync.configs.applicationsHashtable.$_ })
|
|
)
|
|
<#
|
|
|
|
.SYNOPSIS
|
|
Uninstalls the selected programs
|
|
#>
|
|
|
|
if($sync.ProcessRunning) {
|
|
$msg = "[Invoke-WPFUnInstall] Install process is currently running"
|
|
Show-WinUtilMessage -Message $msg -Title "WinUtil" -Button "OK" -Icon "Warning"
|
|
return
|
|
}
|
|
|
|
if ($PackagesToUninstall.Count -eq 0) {
|
|
$WarningMsg = "Please select the program(s) to uninstall"
|
|
Show-WinUtilMessage -Message $WarningMsg -Title "WinUtil" -Button "OK" -Icon "Warning"
|
|
return
|
|
}
|
|
|
|
$ButtonType = "YesNo"
|
|
$MessageboxTitle = "Are you sure?"
|
|
$Messageboxbody = ("This will uninstall the following applications: `n $($PackagesToUninstall | Select-Object Name, Description| Out-String)")
|
|
$MessageIcon = "Information"
|
|
|
|
$confirm = Show-WinUtilMessage -Message $Messageboxbody -Title $MessageboxTitle -Button $ButtonType -Icon $MessageIcon
|
|
|
|
if($confirm -eq "No") {return}
|
|
|
|
$ManagerPreference = $sync.preferences.packagemanager
|
|
Write-WinUtilLog -Component "Uninstall" -Message "Uninstall requested for $(@($PackagesToUninstall).Count) selected package(s) using preference: $ManagerPreference"
|
|
$packageSummary = Get-WinUtilPackageLogSummary -Packages $PackagesToUninstall -Preference $ManagerPreference
|
|
Write-WinUtilLog -Component "Uninstall" -Message "Uninstall selected package(s): $($packageSummary -join '; ')"
|
|
|
|
Invoke-WPFRunspace -ParameterList @(("PackagesToUninstall", $PackagesToUninstall),("ManagerPreference", $ManagerPreference)) -ScriptBlock {
|
|
param($PackagesToUninstall, $ManagerPreference)
|
|
|
|
$packagesSorted = Get-WinUtilSelectedPackages -PackageList $PackagesToUninstall -Preference $ManagerPreference
|
|
|
|
$packagesWinget = $packagesSorted['Winget']
|
|
$packagesChoco = $packagesSorted['Choco']
|
|
$totalPackages = @($packagesWinget).Count + @($packagesChoco).Count
|
|
$completedPackages = 0
|
|
$hasUI = $null -ne $sync.Form -and $null -ne $sync.Form.Dispatcher
|
|
Write-WinUtilLog -Component "Uninstall" -Message "Uninstall package manager split: winget=$(@($packagesWinget).Count), choco=$(@($packagesChoco).Count)"
|
|
|
|
try {
|
|
$sync.ProcessRunning = $true
|
|
if ($hasUI) {
|
|
Set-WinUtilTweaksProgressIndicator -Visible $true -Label "Preparing app uninstall (0/$totalPackages)" -Percent 0
|
|
Invoke-WPFUIThread -ScriptBlock {
|
|
if ($null -ne $sync.ItemsControl) {
|
|
$sync.ItemsControl.IsEnabled = $false
|
|
}
|
|
}
|
|
}
|
|
|
|
if ($packagesWinget -contains "Microsoft.Edge") {
|
|
New-Item -Path "$Env:SystemRoot\SystemApps\Microsoft.MicrosoftEdge_8wekyb3d8bbwe\MicrosoftEdge.exe" -Force
|
|
}
|
|
|
|
# Uninstall all selected programs in new window
|
|
if($packagesWinget.Count -gt 0) {
|
|
foreach ($program in $packagesWinget) {
|
|
$position = $completedPackages + 1
|
|
$startPercent = [int](($completedPackages / $totalPackages) * 100)
|
|
if ($hasUI) {
|
|
Set-WinUtilTweaksProgressIndicator -Visible $true -Label "Uninstalling $program ($position/$totalPackages)" -Percent $startPercent
|
|
}
|
|
|
|
Install-WinUtilProgramWinget -Action Uninstall -Programs @($program)
|
|
$completedPackages++
|
|
$completedPercent = [int](($completedPackages / $totalPackages) * 100)
|
|
if ($hasUI) {
|
|
Set-WinUtilTweaksProgressIndicator -Visible $true -Label "Uninstalled $program ($completedPackages/$totalPackages)" -Percent $completedPercent
|
|
Invoke-WPFUIThread -ScriptBlock { Set-WinUtilTaskbaritem -value ($completedPercent / 100) }
|
|
}
|
|
}
|
|
}
|
|
if($packagesChoco.Count -gt 0) {
|
|
$position = $completedPackages + 1
|
|
$startPercent = [int](($completedPackages / $totalPackages) * 100)
|
|
if ($hasUI) {
|
|
Set-WinUtilTweaksProgressIndicator -Visible $true -Label "Uninstalling Chocolatey packages ($position/$totalPackages)" -Percent $startPercent
|
|
}
|
|
|
|
Install-WinUtilProgramChoco -Action Uninstall -Programs $packagesChoco
|
|
$completedPackages += @($packagesChoco).Count
|
|
$completedPercent = [int](($completedPackages / $totalPackages) * 100)
|
|
if ($hasUI) {
|
|
Set-WinUtilTweaksProgressIndicator -Visible $true -Label "Uninstalled Chocolatey packages ($completedPackages/$totalPackages)" -Percent $completedPercent
|
|
Invoke-WPFUIThread -ScriptBlock { Set-WinUtilTaskbaritem -value ($completedPercent / 100) }
|
|
}
|
|
}
|
|
Write-Host "==========================================="
|
|
Write-Host "-- Uninstalls have finished ---"
|
|
Write-Host "==========================================="
|
|
Write-WinUtilLog -Component "Uninstall" -Message "Uninstall workflow completed."
|
|
if ($hasUI) {
|
|
Set-WinUtilTweaksProgressIndicator -Visible $true -Label "App uninstall finished" -Percent 100
|
|
Invoke-WPFUIThread -ScriptBlock { Set-WinUtilTaskbaritem -state "None" -overlay "checkmark" }
|
|
}
|
|
} catch {
|
|
Write-Host "==========================================="
|
|
Write-Host "Error: $_"
|
|
Write-Host "==========================================="
|
|
Write-WinUtilLog -Level "ERROR" -Component "Uninstall" -Message "Uninstall workflow failed: $($_.Exception.Message)"
|
|
if ($hasUI) {
|
|
Set-WinUtilTweaksProgressIndicator -Visible $true -Label "App uninstall failed" -Percent 100
|
|
Invoke-WPFUIThread -ScriptBlock { Set-WinUtilTaskbaritem -state "Error" -overlay "warning" }
|
|
}
|
|
} finally {
|
|
if ($hasUI) {
|
|
Invoke-WPFUIThread -ScriptBlock {
|
|
if ($null -ne $sync.ItemsControl) {
|
|
$sync.ItemsControl.IsEnabled = $true
|
|
}
|
|
}
|
|
}
|
|
$sync.ProcessRunning = $False
|
|
}
|
|
|
|
}
|
|
}
|