From ca85d0d4cac9d5866c6bf954ca3ec5ecf28ff675 Mon Sep 17 00:00:00 2001 From: Jazzzny Date: Sun, 28 May 2023 11:42:52 -0400 Subject: [PATCH 1/6] Add workaround for MenuBar2 crashing --- data/sys_patch_dict.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/data/sys_patch_dict.py b/data/sys_patch_dict.py index 9df67bf90..c4df8d647 100644 --- a/data/sys_patch_dict.py +++ b/data/sys_patch_dict.py @@ -147,6 +147,9 @@ class SystemPatchDictionary(): **({"defaults write /Library/Preferences/.GlobalPreferences.plist ShowDate -int 1": True } if self.os_float >= self.macOS_12_4 else {}), "defaults write /Library/Preferences/.GlobalPreferences.plist InternalDebugUseGPUProcessForCanvasRenderingEnabled -bool false": True, "defaults write /Library/Preferences/.GlobalPreferences.plist WebKitExperimentalUseGPUProcessForCanvasRenderingEnabled -bool false": True, + # MenuBar2 breaks macOS if enabled before patching + "defaults write -g Amy.MenuBar2Beta -bool false": True, + }, }, "Non-Metal IOAccelerator Common": { From dd1b60c8bec95184beb3c9e6c84f56ede4b4594a Mon Sep 17 00:00:00 2001 From: Jazzzny Date: Sun, 28 May 2023 14:44:00 -0400 Subject: [PATCH 2/6] Use full pathing --- data/sys_patch_dict.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/sys_patch_dict.py b/data/sys_patch_dict.py index c4df8d647..3f3306a71 100644 --- a/data/sys_patch_dict.py +++ b/data/sys_patch_dict.py @@ -148,7 +148,7 @@ class SystemPatchDictionary(): "defaults write /Library/Preferences/.GlobalPreferences.plist InternalDebugUseGPUProcessForCanvasRenderingEnabled -bool false": True, "defaults write /Library/Preferences/.GlobalPreferences.plist WebKitExperimentalUseGPUProcessForCanvasRenderingEnabled -bool false": True, # MenuBar2 breaks macOS if enabled before patching - "defaults write -g Amy.MenuBar2Beta -bool false": True, + "defaults write ~/Library/Preferences/.GlobalPreferences.plist Amy.MenuBar2Beta -bool false": True, }, }, From efdb278691ae085fd5b6270fe8d081b2fa2d8bb9 Mon Sep 17 00:00:00 2001 From: Jazzzny Date: Sun, 28 May 2023 14:48:10 -0400 Subject: [PATCH 3/6] oopsies --- data/sys_patch_dict.py | 1 - 1 file changed, 1 deletion(-) diff --git a/data/sys_patch_dict.py b/data/sys_patch_dict.py index 3f3306a71..64afd15a2 100644 --- a/data/sys_patch_dict.py +++ b/data/sys_patch_dict.py @@ -149,7 +149,6 @@ class SystemPatchDictionary(): "defaults write /Library/Preferences/.GlobalPreferences.plist WebKitExperimentalUseGPUProcessForCanvasRenderingEnabled -bool false": True, # MenuBar2 breaks macOS if enabled before patching "defaults write ~/Library/Preferences/.GlobalPreferences.plist Amy.MenuBar2Beta -bool false": True, - }, }, "Non-Metal IOAccelerator Common": { From c0f951411a761b405b19ee8dfe887030efdf0a00 Mon Sep 17 00:00:00 2001 From: Jazzzny Date: Tue, 30 May 2023 16:32:41 -0400 Subject: [PATCH 4/6] Change to global .plist file --- data/sys_patch_dict.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/sys_patch_dict.py b/data/sys_patch_dict.py index 64afd15a2..b526a5b1b 100644 --- a/data/sys_patch_dict.py +++ b/data/sys_patch_dict.py @@ -148,7 +148,7 @@ class SystemPatchDictionary(): "defaults write /Library/Preferences/.GlobalPreferences.plist InternalDebugUseGPUProcessForCanvasRenderingEnabled -bool false": True, "defaults write /Library/Preferences/.GlobalPreferences.plist WebKitExperimentalUseGPUProcessForCanvasRenderingEnabled -bool false": True, # MenuBar2 breaks macOS if enabled before patching - "defaults write ~/Library/Preferences/.GlobalPreferences.plist Amy.MenuBar2Beta -bool false": True, + "defaults write /Library/Preferences/.GlobalPreferences.plist Amy.MenuBar2Beta -bool false": True, }, }, "Non-Metal IOAccelerator Common": { From 41ce771c33d5cc0955a57d43739184bb52359208 Mon Sep 17 00:00:00 2001 From: Jazzzny Date: Tue, 30 May 2023 16:42:22 -0400 Subject: [PATCH 5/6] Update CHANGELOG --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index dfaedcd88..a7c0c0a73 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ - Allows for Live Text support on systems with3802 GPUs - ie. Intel Ivy Bridge and Haswell, Nvidia Kepler - Previously disabled due to high instability in Photos with Face Scanning, now resolved +- Resolve crashing after patching with MenuBar2 implementation enabled - Backend changes: - Call `setpgrp()` to prevent app from being killed if parent process is killed (ie. LaunchAgents) - Resolve payloads path being mis-routed during CLI calls From e99de2360a25d87afbc28ca6928b60a642066c50 Mon Sep 17 00:00:00 2001 From: Jazzzny Date: Tue, 30 May 2023 16:42:59 -0400 Subject: [PATCH 6/6] Update --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index a7c0c0a73..abf13d87d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ - ie. Intel Ivy Bridge and Haswell, Nvidia Kepler - Previously disabled due to high instability in Photos with Face Scanning, now resolved - Resolve crashing after patching with MenuBar2 implementation enabled + - Setting must be re-enabled after patching - Backend changes: - Call `setpgrp()` to prevent app from being killed if parent process is killed (ie. LaunchAgents) - Resolve payloads path being mis-routed during CLI calls