From f5c511366eb7b136c2040e603ff670227f3f1321 Mon Sep 17 00:00:00 2001 From: Mykola Grymalyuk <48863253+khronokernel@users.noreply.github.com> Date: Tue, 4 May 2021 14:07:50 -0600 Subject: [PATCH] Fix NightShift disabling on Minimal SMBIOS configs --- CHANGELOG.md | 1 + OpenCore-Patcher.command | 2 +- README.md | 62 +++++++++++++++++----------------------- Resources/Build.py | 2 +- docs/LICENSE.md | 4 +++ docs/START.md | 10 ++++++- 6 files changed, 42 insertions(+), 39 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f7ead6cfa..bc66e3d32 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ - Increment binaries - AppleALC f2889fc (1.6.1 rolling - 05-03-2021) - Support custom CPU names in About This Mac +- Fix NightShift accidentally disabling on Minimal SMBIOS configs ## 0.1.2 - Fix IDE support on 2008 era MacBooks, iMacs and Xserves diff --git a/OpenCore-Patcher.command b/OpenCore-Patcher.command index 8aeccf4f1..09e24f3da 100755 --- a/OpenCore-Patcher.command +++ b/OpenCore-Patcher.command @@ -139,7 +139,7 @@ system_profiler SPHardwareDataType | grep 'Model Identifier' - ASentientBot:\tLegacy Acceleration Patches - Ausdauersportler:\tLinking fixes for SNBGraphicsFB and AMDX3000 - Syncretic:\t\tAAAMouSSE and telemetrap - - cdf:\t\tNightShiftEnabler"""]).start() + - cdf:\t\tNightShiftEnabler and Innie"""]).start() def PatchVolume(self): Utilities.cls() diff --git a/README.md b/README.md index 57b5eb576..45a17293e 100644 --- a/README.md +++ b/README.md @@ -2,60 +2,50 @@ -A python program for building and booting [OpenCore](https://github.com/acidanthera/OpenCorePkg) on legacy Macs, see [Supported SMBIOS](https://dortania.github.io/OpenCore-Legacy-Patcher/MODELS.html) on whether your model is supported. Designed around Big Sur support, however can be used on older OSes. - -| Support Entry | Supported OSes | Description | Comment | -| :--- | :--- | :--- | :--- | -| HostOS | macOS 10.9 - macOS 11 | Refers to OSes where running OpenCore-Patcher.app are supported | Supports 10.7+ if [Python 3.6 or higher](https://www.python.org/downloads/) is manually installed, simply run the `OpenCore-Patcher.command` located in the repo | -| TargetOS | macOS 11 | Refers to OSes that can be patched to run with OpenCore | May support 10.4 and newer (in a potentially broken state). No support provided. | +A python program for building and booting [OpenCore](https://github.com/acidanthera/OpenCorePkg) on both legacy and modern Macs, see our in-depth [Guide](https://dortania.github.io/OpenCore-Legacy-Patcher/) for more information. Supported features: * System Integrity Protection, FileVault 2, .im4m Secure Boot and Vaulting +* WPA Wifi and Personal Hotspot support * Native OTA OS DELTA updates on all Macs * Recovery OS, Safe Mode and Single-user Mode booting * Zero firmware patching required (ie. APFS ROM patching) * GPU Switching on MacBook Pro models (2012 and newer) -Note: Only clean-installs and upgrades are supported, installs already patched with other patchers, such as [Patched Sur](https://github.com/BenSova/Patched-Sur) or [bigmac](https://github.com/StarPlayrX/bigmac), cannot be used due to broken file integrity with APFS snapshots and SIP. +Note: Only clean-installs and upgrades are supported, macOS Big Sur installs already patched with other patchers, such as [Patched Sur](https://github.com/BenSova/Patched-Sur) or [bigmac](https://github.com/StarPlayrX/bigmac), cannot be used due to broken file integrity with APFS snapshots and SIP. * You can however reinstall macOS with this patcher and retain your original data Note 2: Currently OpenCore Legacy Patcher officially supports patching to run macOS 11, Big Sur installs. For older OSes, OpenCore may function however support is currently not provided from Dortania. -For Mojave and Catalina support, we recommend the use of [dosdude1's patchers](http://dosdude1.com) - -## How to use - -See the online guide on how: - -* [OpenCore Legacy Patcher Guide](https://dortania.github.io/OpenCore-Legacy-Patcher/) - -## Patcher Warnings - -Since this patcher tricks macOS into thinking you're running a newer Mac, certain functionality may be broken: - -* Boot Camp Assistant.app - * We recommend running the assistant on a natively supported OS, running via the patcher may result in unforeseen issues -* Legacy Windows Booting - * Currently OpenCore cannot boot MBR-based installs, so Ivy Bridge and older Machines may [not be able to see Windows in OpenCore's Boot Picker](https://github.com/acidanthera/bugtracker/issues/912) - * [Solution is to convert install to UEFI](https://docs.microsoft.com/en-us/mem/configmgr/osd/deploy-use/task-sequence-steps-to-manage-bios-to-uefi-conversion), see MacRumors thread for more examples: [Installing Windows 10](https://forums.macrumors.com/threads/opencore-on-the-mac-pro.2207814/) - * You can still boot BootCamp outside of OpenCore just like before however! -* Boot Buddy support - * Due to how OpenCore overwrites NVRAM, the usage of Boot Buddy and such tools are **highly** in-advised +* For Mojave and Catalina support, we recommend the use of [dosdude1's patchers](http://dosdude1.com) ## Support -To get aid with the patcher, we recommend joining the [OpenCore Patcher Paradise Discord Server](https://discord.gg/rqdPgH8xSN). We're actively there and is the quickest way to receive help. For bigger issues such as patcher crashing on build and such, we recommend opening an issue right here on GitHub: +To get aid with the patcher, we recommend joining the [OpenCore Patcher Paradise Discord Server](https://discord.gg/rqdPgH8xSN). We're actively there and is the quickest way to receive help. For bigger issues such as patcher crashing on build and such, we recommend opening an issue right here on GitHub(Please review [How to debug with OpenCore](https://dortania.github.io/OpenCore-Legacy-Patcher/DEBUG.html) before opening issues): * [OpenCore Legacy Patcher's Issue's tab](https://github.com/dortania/OpenCore-Legacy-Patcher/issues) -Regarding how to debug OpenCore Patcher, we recommend seeing the below: +## Credits -* [How to debug with OpenCore](https://dortania.github.io/OpenCore-Legacy-Patcher/DEBUG.html) - -## Supporting us! - -To help support this patcher, we recommend checking this page: - -* [Supporting the patcher](https://dortania.github.io/OpenCore-Legacy-Patcher/DONATE.html) +* [Acidanthera](https://github.com/Acidanthera) + * OpenCorePkg as well as many of the core kexts and tools +* [DhinakG](https://github.com/DhinakG) + * Main co-author +* [Khronokernel](https://github.com/Khronokernel) + * Main co-author +* [Ausdauersportler](https://github.com/Ausdauersportler) + * iMacs Metal GPUs Upgrade Patch set and documentation +* [ASentientBot](https://github.com/ASentientBot) + * Legacy Acceleration Patch set and documentation +* [cdf](https://github.com/cdf) + * Mac Pro on OpenCore Patch set and documentation +* [dosdude1](https://github.com/dosdude1) and [BarryKN](https://github.com/BarryKN) + * Development of previous patchers, laying out much of what needs to be patched +* [vit9696](https://github.com/vit9696) + * Endless amount of help troubleshooting, determining fixes and writing patches +* [mario_bros_tech](https://github.com/mariobrostech) and the rest of the Unsupported Mac Discord + * Catalyst that started OpenCore Legacy Patcher +* MacRumors and Unsupported Mac Communities + * Endless testing, reporting issues diff --git a/Resources/Build.py b/Resources/Build.py index 267f08b8a..ddcf98489 100644 --- a/Resources/Build.py +++ b/Resources/Build.py @@ -113,7 +113,7 @@ class BuildOpenCore: ("WhateverGreen.kext", self.constants.whatevergreen_version, self.constants.whatevergreen_path, lambda: self.constants.allow_oc_everywhere is False), ("RestrictEvents.kext", self.constants.restrictevents_version, self.constants.restrictevents_path, lambda: self.model in ModelArray.MacPro71), ("RestrictEvents.kext", self.constants.restrictevents_mbp_version, self.constants.restrictevents_mbp_path, lambda: self.model == "MacBookPro9,1"), - ("NightShiftEnabler.kext", self.constants.nightshift_version, self.constants.nightshift_path, lambda: self.model not in ModelArray.NightShiftExclude and self.constants.allow_oc_everywhere is False and self.constants.serial_settings == "Moderate"), + ("NightShiftEnabler.kext", self.constants.nightshift_version, self.constants.nightshift_path, lambda: self.model not in ModelArray.NightShiftExclude and self.constants.allow_oc_everywhere is False and self.constants.serial_settings == "Minimal"), ("SMC-Spoof.kext", self.constants.smcspoof_version, self.constants.smcspoof_path, lambda: self.constants.allow_oc_everywhere is False), # CPU patches ("AppleMCEReporterDisabler.kext", self.constants.mce_version, self.constants.mce_path, lambda: self.model in ModelArray.DualSocket), diff --git a/docs/LICENSE.md b/docs/LICENSE.md index ccbc2adfa..34e1d6f17 100644 --- a/docs/LICENSE.md +++ b/docs/LICENSE.md @@ -10,9 +10,13 @@ This patcher is made of multiple external applications from different people and * [CPUFriend](https://github.com/acidanthera/CPUFriend/blob/master/LICENSE) * [RestrictEvents](https://github.com/acidanthera/RestrictEvents/blob/master/LICENSE.txt) * [NightShiftEnabler](https://github.com/cdf/NightShiftEnabler/blob/master/LICENSE.txt) + * [Innie](https://github.com/cdf/Innie/blob/master/LICENSE.txt) +* GPL 2.0 + * [NVMeFix](https://github.com/acidanthera/NVMeFix/blob/master/LICENSE.txt) * All rights reserved to respective authors * [AAAMouSSE](https://forums.macrumors.com/threads/mp3-1-others-sse-4-2-emulation-to-enable-amd-metal-driver.2206682/) - Syncretic * [telemetrap](https://forums.macrumors.com/threads/mp3-1-others-sse-4-2-emulation-to-enable-amd-metal-driver.2206682/post-28447707) - Syncretic + * [SidecarFixup](https://github.com/khronokernel/SidecarFixup) - Khronokernel * Apple Binaries - Apple Inc. Remaining files within OpenCore Legacy Patcher are copyrighted 2020-2021 Mykola Grymalyuk & Dhinak G, under the BSD-3 Clause license: diff --git a/docs/START.md b/docs/START.md index cc1ce36d2..c2428c625 100644 --- a/docs/START.md +++ b/docs/START.md @@ -5,12 +5,20 @@ This is a sophisticated boot loader used to inject and patch data in memory, ins * System Integrity Protection, FileVault 2, .im4m Secure Boot and Vaulting * Native OTA OS DELTA updates on all Macs * Recovery OS, Safe Mode and Single-user Mode booting +* WPA Wifi and Personal Hotspot support While many PC users from the Hackintosh community are familiar with OpenCore, OpenCore was designed as Mac and PC agnostic ensuring both platforms can use it easily. And with OpenCore Legacy Patcher, we help automate the process making running with OpenCore that much easier. For advanced troubleshooting, we highly recommend users check out the [OpenCore Patcher Paradise Discord Server](https://discord.gg/rqdPgH8xSN) as this is generally the quickest way to get a hold of us developers and get help from the community. -For those who wish to support this patcher, please see the [Supporting the Patcher page](./DONATE.md) +For those who wish to support this patcher, please see the [Supporting the Patcher page](./DONATE.md) + +## Patcher Warnings + +Since this patcher tricks macOS into thinking you're running a newer Mac, certain functionality may be broken: + +* Boot Camp Assistant.app + * We recommend following our [guide on getting a UEFI Windows Install working](). Legacy MBR Based installs won't show up in OpenCore ## How do I get started?