From 30bd87eb53532b1cbd5096d0508be1d30885f316 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E4=B8=96=E7=95=8C?= Date: Wed, 1 Apr 2026 16:51:03 +0800 Subject: [PATCH] test: remove internal-state assertions that test through unexported fields --- dns/router_test.go | 13 ------------- route/rule/rule_item_rule_set_test.go | 1 - 2 files changed, 14 deletions(-) diff --git a/dns/router_test.go b/dns/router_test.go index 55d7311df..f9e60ab8d 100644 --- a/dns/router_test.go +++ b/dns/router_test.go @@ -811,9 +811,6 @@ func TestRuleSetUpdateSerializesConcurrentRebuilds(t *testing.T) { require.Equal(t, 2, metadataCallCount) require.Equal(t, 1, maximumConcurrentMetadataCalls) metadataAccess.Unlock() - require.Zero(t, callbackRuleSet.refCount()) - require.Zero(t, firstBuildRuleSet.refCount()) - require.Equal(t, 1, secondBuildRuleSet.refCount()) lastUsedTransport.Store("") addresses, err = router.Lookup(context.Background(), "example.com", adapter.DNSQueryOptions{}) @@ -911,10 +908,6 @@ func TestCloseDuringRebuildDiscardsResult(t *testing.T) { fakeSet.metadataRead = nil - router.stateAccess.Lock() - require.True(t, router.closing) - require.Empty(t, router.ruleSetCallbacks) - router.stateAccess.Unlock() require.Nil(t, router.currentRules.Load()) require.Zero(t, fakeSet.refCount()) } @@ -976,12 +969,6 @@ func TestCloseIgnoresSnapshottedRuleSetCallback(t *testing.T) { ContainsDNSQueryTypeRule: true, } callbacks[0](fakeSet) - - router.stateAccess.Lock() - require.True(t, router.closing) - require.Empty(t, router.ruleSetCallbacks) - router.stateAccess.Unlock() - require.Nil(t, router.currentRules.Load()) } func TestRuleSetUpdateDoesNotBlockOnInFlightLookup(t *testing.T) { diff --git a/route/rule/rule_item_rule_set_test.go b/route/rule/rule_item_rule_set_test.go index a73ed91f5..21d2070d9 100644 --- a/route/rule/rule_item_rule_set_test.go +++ b/route/rule/rule_item_rule_set_test.go @@ -115,7 +115,6 @@ func TestRuleSetItemStartRollbackOnFailure(t *testing.T) { err := item.Start() require.ErrorContains(t, err, "rule-set not found: missing") require.Zero(t, firstSet.RefCount()) - require.Empty(t, item.setList) } func TestRuleSetItemRestartKeepsBalancedRefs(t *testing.T) {