From 3d7a4ca324ec19b5c8e471d6e03496d01cf385d6 Mon Sep 17 00:00:00 2001 From: Baptiste Augrain Date: Sun, 25 Feb 2024 18:37:47 +0100 Subject: [PATCH] ci(linux): bypass build job to generate all assets [skip ci] --- .github/workflows/stable-linux.yml | 31 +++++++++++++-------- stores/snapcraft/stable/snap/snapcraft.yaml | 4 +-- 2 files changed, 22 insertions(+), 13 deletions(-) diff --git a/.github/workflows/stable-linux.yml b/.github/workflows/stable-linux.yml index 802f1d3..e389303 100644 --- a/.github/workflows/stable-linux.yml +++ b/.github/workflows/stable-linux.yml @@ -70,42 +70,48 @@ jobs: MS_COMMIT: ${{ needs.check.outputs.MS_COMMIT }} MS_TAG: ${{ needs.check.outputs.MS_TAG }} RELEASE_VERSION: ${{ needs.check.outputs.RELEASE_VERSION }} - SHOULD_BUILD: 'yes' + SHOULD_BUILD: ${{ (needs.check.outputs.SHOULD_BUILD == 'yes' || github.event.inputs.generate_assets == 'true') && 'yes' || 'no' }} VSCODE_ARCH: 'x64' outputs: BUILD_SOURCEVERSION: ${{ env.BUILD_SOURCEVERSION }} - if: needs.check.outputs.SHOULD_BUILD == 'yes' || github.event.inputs.generate_assets == 'true' steps: - uses: actions/checkout@v4 with: ref: ${{ env.GITHUB_BRANCH }} + if: env.SHOULD_BUILD == 'yes' - name: Setup Node.js environment uses: actions/setup-node@v4 with: node-version: '18.17' + if: env.SHOULD_BUILD == 'yes' - name: Install Yarn run: npm install -g yarn + if: env.SHOULD_BUILD == 'yes' - name: Setup Python 3 uses: actions/setup-python@v5 with: python-version: '3.11' + if: env.SHOULD_BUILD == 'yes' - name: Install libkrb5-dev run: sudo apt-get install -y libkrb5-dev + if: env.SHOULD_BUILD == 'yes' - name: Clone VSCode repo env: PULL_REQUEST_ID: ${{ github.event.inputs.checkout_pr }} run: ./get_repo.sh + if: needs.check.outputs.SHOULD_BUif: env.SHOULD_BUILD == 'yes' - name: Build env: SHOULD_BUILD_REH: 'no' run: ./build.sh + if: env.SHOULD_BUILD == 'yes' - name: Compress vscode artifact run: | @@ -113,6 +119,7 @@ jobs: echo "vscode/.build/extensions/node_modules" >> vscode.txt echo "vscode/.git" >> vscode.txt tar -czf vscode.tar.gz -T vscode.txt + if: env.SHOULD_BUILD == 'yes' - name: Upload vscode artifact uses: actions/upload-artifact@v3 @@ -120,6 +127,7 @@ jobs: name: vscode path: ./vscode.tar.gz retention-days: ${{ needs.check.outputs.SHOULD_DEPLOY == 'yes' && 30 || 1 }} + if: env.SHOULD_BUILD == 'yes' build: needs: @@ -146,52 +154,53 @@ jobs: MS_COMMIT: ${{ needs.check.outputs.MS_COMMIT }} MS_TAG: ${{ needs.check.outputs.MS_TAG }} RELEASE_VERSION: ${{ needs.check.outputs.RELEASE_VERSION }} - SHOULD_BUILD: ${{ needs.check.outputs.SHOULD_BUILD }} + SHOULD_BUILD: ${{ (needs.check.outputs.SHOULD_BUILD == 'yes' || github.event.inputs.generate_assets == 'true') && 'yes' || 'no' }} SHOULD_DEPLOY: ${{ needs.check.outputs.SHOULD_DEPLOY }} VSCODE_ARCH: ${{ matrix.vscode_arch }} outputs: RELEASE_VERSION: ${{ env.RELEASE_VERSION }} SHOULD_BUILD: ${{ env.SHOULD_BUILD }} SHOULD_DEPLOY: ${{ env.SHOULD_DEPLOY }} - if: needs.check.outputs.SHOULD_BUILD == 'yes' || github.event.inputs.generate_assets == 'true' steps: - uses: actions/checkout@v3 with: ref: ${{ env.GITHUB_BRANCH }} + if: env.SHOULD_BUILD == 'yes' - name: Install GH run: ./install_gh.sh - if: env.SHOULD_DEPLOY == 'yes' + if: env.SHOULD_BUILD == 'yes' && env.SHOULD_DEPLOY == 'yes' - name: Check existing VSCodium tags/releases env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} CHECK_REH: 'no' run: ./check_tags.sh + if: env.SHOULD_BUILD == 'yes' - name: Install libkrb5-dev run: sudo apt-get install -y libkrb5-dev - if: env.SHOULD_BUILD == 'yes' || github.event.inputs.generate_assets == 'true' + if: env.SHOULD_BUILD == 'yes' - name: Download vscode artifact uses: actions/download-artifact@v3 with: name: vscode - if: env.SHOULD_BUILD == 'yes' || github.event.inputs.generate_assets == 'true' + if: env.SHOULD_BUILD == 'yes' - name: Build env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} npm_config_arch: ${{ matrix.npm_arch }} run: ./package_linux_bin.sh - if: env.SHOULD_BUILD == 'yes' || github.event.inputs.generate_assets == 'true' + if: env.SHOULD_BUILD == 'yes' - name: Prepare assets env: SHOULD_BUILD_REH: 'no' run: ./prepare_assets.sh - if: (env.SHOULD_BUILD == 'yes' && env.SHOULD_DEPLOY == 'yes') || github.event.inputs.generate_assets == 'true' + if: env.SHOULD_BUILD == 'yes' && (env.SHOULD_DEPLOY == 'yes' || github.event.inputs.generate_assets == 'true') - name: Release env: @@ -213,7 +222,7 @@ jobs: name: bin-${{ matrix.vscode_arch }} path: assets/ retention-days: 3 - if: env.SHOULD_DEPLOY == 'no' && github.event.inputs.generate_assets == 'true' + if: env.SHOULD_BUILD == 'yes' && env.SHOULD_DEPLOY == 'no' && github.event.inputs.generate_assets == 'true' reh: needs: @@ -322,7 +331,7 @@ jobs: platform: - amd64 - arm64 - if: needs.build.outputs.SHOULD_DEPLOY == 'yes' || github.event.inputs.generate_assets == 'true' + if: needs.check.outputs.SHOULD_DEPLOY == 'yes' || github.event.inputs.generate_assets == 'true' steps: - uses: actions/checkout@v3 diff --git a/stores/snapcraft/stable/snap/snapcraft.yaml b/stores/snapcraft/stable/snap/snapcraft.yaml index 1443cd6..2f4efdd 100644 --- a/stores/snapcraft/stable/snap/snapcraft.yaml +++ b/stores/snapcraft/stable/snap/snapcraft.yaml @@ -81,8 +81,8 @@ parts: apps: codium: - command: electron-launch $SNAP/snap/usr/share/codium/bin/codium --no-sandbox + command: electron-launch $SNAP/usr/share/codium/bin/codium --no-sandbox common-id: codium.desktop url-handler: - command: electron-launch $SNAP/snap/usr/share/codium/bin/codium --open-url --no-sandbox + command: electron-launch $SNAP/usr/share/codium/bin/codium --open-url --no-sandbox