From 7132e64cf0e5bfe81401cfd43f2eb306c3ee0d21 Mon Sep 17 00:00:00 2001 From: Baptiste Augrain Date: Sat, 18 Apr 2026 03:08:04 +0200 Subject: [PATCH] ci: don't use env variable or upper function --- .github/workflows/ci-build-linux.yml | 12 ++++++------ .github/workflows/ci-build-macos.yml | 4 ++-- .github/workflows/ci-build-windows.yml | 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/ci-build-linux.yml b/.github/workflows/ci-build-linux.yml index 32ee97f..dc09cbf 100644 --- a/.github/workflows/ci-build-linux.yml +++ b/.github/workflows/ci-build-linux.yml @@ -24,13 +24,13 @@ on: env: ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true APP_NAME: VSCodium - VSCODE_QUALITY: ${{ (github.ref == 'refs/heads/insider' || (github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'insider')) && 'insider' || 'stable' }} - BINARY_NAME: ${{ env.VSCODE_QUALITY == 'insider' && 'codium-insiders' || 'codium' }} + BINARY_NAME: ${{ (github.ref == 'refs/heads/insider' || (github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'insider')) && 'codium-insiders' || 'codium' }} DISABLE_UPDATE: yes GH_REPO_PATH: ${{ github.repository }} GITHUB_BRANCH: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.event.head }} ORG_NAME: ${{ github.repository_owner }} OS_NAME: linux + VSCODE_QUALITY: ${{ (github.ref == 'refs/heads/insider' || (github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'insider')) && 'insider' || 'stable' }} permissions: {} @@ -134,7 +134,7 @@ jobs: image: ${{ matrix.image }} env: BUILD_SOURCEVERSION: ${{ needs.compile.outputs.BUILD_SOURCEVERSION }} - DISABLED: ${{ vars[format('DISABLE_{0}_LINUX_APP_{1}', toUpper(env.VSCODE_QUALITY), matrix.slug)] }} + DISABLED: ${{ vars[format('DISABLE_{0}_LINUX_APP_{1}', ((github.ref == 'refs/heads/insider' || (github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'insider')) && 'INSIDER' || 'STABLE'), matrix.slug)] }} MS_COMMIT: ${{ needs.compile.outputs.MS_COMMIT }} MS_TAG: ${{ needs.compile.outputs.MS_TAG }} RELEASE_VERSION: ${{ needs.compile.outputs.RELEASE_VERSION }} @@ -182,7 +182,7 @@ jobs: - name: Prepare assets env: - SHOULD_BUILD_APPIMAGE: ${{ (vars[format('DISABLE_{0}_APPIMAGE', toUpper(env.VSCODE_QUALITY)] == 'yes') && 'no' || 'yes' }} + SHOULD_BUILD_APPIMAGE: ${{ (vars[format('DISABLE_{0}_APPIMAGE', ((github.ref == 'refs/heads/insider' || (github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'insider')) && 'INSIDER' || 'STABLE'))] == 'yes' && 'no' || 'yes' }} SHOULD_BUILD_REH: 'no' SHOULD_BUILD_REH_WEB: 'no' VSCODE_SYSROOT_REPOSITORY: ${{ steps.build.outputs.VSCODE_SYSROOT_REPOSITORY }} @@ -230,7 +230,7 @@ jobs: npm_arch: s390x env: BUILD_SOURCEVERSION: ${{ needs.compile.outputs.BUILD_SOURCEVERSION }} - DISABLED: ${{ vars[format('DISABLE_{0}_LINUX_REH_{1}', toUpper(env.VSCODE_QUALITY), matrix.slug)] }} + DISABLED: ${{ vars[format('DISABLE_{0}_LINUX_REH_{1}', ((github.ref == 'refs/heads/insider' || (github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'insider')) && 'INSIDER' || 'STABLE'), matrix.slug)] }} MS_COMMIT: ${{ needs.compile.outputs.MS_COMMIT }} MS_TAG: ${{ needs.compile.outputs.MS_TAG }} RELEASE_VERSION: ${{ needs.compile.outputs.RELEASE_VERSION }} @@ -313,7 +313,7 @@ jobs: npm_arch: arm64 env: BUILD_SOURCEVERSION: ${{ needs.compile.outputs.BUILD_SOURCEVERSION }} - DISABLED: ${{ vars[format('DISABLE_{0}_ALPINE_REH_{1}', toUpper(env.VSCODE_QUALITY), matrix.slug)] }} + DISABLED: ${{ vars[format('DISABLE_{0}_ALPINE_REH_{1}', ((github.ref == 'refs/heads/insider' || (github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'insider')) && 'INSIDER' || 'STABLE'), matrix.slug)] }} MS_COMMIT: ${{ needs.compile.outputs.MS_COMMIT }} MS_TAG: ${{ needs.compile.outputs.MS_TAG }} OS_NAME: alpine diff --git a/.github/workflows/ci-build-macos.yml b/.github/workflows/ci-build-macos.yml index 30c5363..b386c7f 100644 --- a/.github/workflows/ci-build-macos.yml +++ b/.github/workflows/ci-build-macos.yml @@ -23,12 +23,12 @@ on: env: APP_NAME: VSCodium - VSCODE_QUALITY: ${{ (github.ref == 'refs/heads/insider' || (github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'insider')) && 'insider' || 'stable' }} - BINARY_NAME: ${{ env.VSCODE_QUALITY == 'insider' && 'codium-insiders' || 'codium' }} + BINARY_NAME: ${{ (github.ref == 'refs/heads/insider' || (github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'insider')) && 'codium-insiders' || 'codium' }} GH_REPO_PATH: ${{ github.repository }} GITHUB_BRANCH: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.event.head }} ORG_NAME: ${{ github.repository_owner }} OS_NAME: osx + VSCODE_QUALITY: ${{ (github.ref == 'refs/heads/insider' || (github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'insider')) && 'insider' || 'stable' }} permissions: {} diff --git a/.github/workflows/ci-build-windows.yml b/.github/workflows/ci-build-windows.yml index fc843b5..8fd81ec 100644 --- a/.github/workflows/ci-build-windows.yml +++ b/.github/workflows/ci-build-windows.yml @@ -23,12 +23,12 @@ on: env: APP_NAME: VSCodium - VSCODE_QUALITY: ${{ (github.ref == 'refs/heads/insider' || (github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'insider')) && 'insider' || 'stable' }} - BINARY_NAME: ${{ env.VSCODE_QUALITY == 'insider' && 'codium-insiders' || 'codium' }} + BINARY_NAME: ${{ (github.ref == 'refs/heads/insider' || (github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'insider')) && 'codium-insiders' || 'codium' }} GH_REPO_PATH: ${{ github.repository }} GITHUB_BRANCH: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.event.head }} ORG_NAME: ${{ github.repository_owner }} OS_NAME: windows + VSCODE_QUALITY: ${{ (github.ref == 'refs/heads/insider' || (github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'insider')) && 'insider' || 'stable' }} permissions: {} @@ -140,7 +140,7 @@ jobs: - name: Build env: - DISABLE_MSI: ${{ vars[format('DISABLE_{0}_MSI', toUpper(env.VSCODE_QUALITY)] }} + DISABLE_MSI: ${{ vars[format('DISABLE_{0}_MSI', ((github.ref == 'refs/heads/insider' || (github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'insider')) && 'INSIDER' || 'STABLE')] }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} npm_config_arch: ${{ matrix.vscode_arch }} npm_config_target_arch: ${{ matrix.vscode_arch }}