Fix for potential crash introduced in 1b013c3

Fixes #1245
Update README.md
2026-04-14 20:58:29 +10:00 · 2022-12-14 16:10:10 +01:00 · 2022-12-08 15:23:34 +01:00 · 2022-12-07 11:58:37 +01:00 · 2022-12-07 11:58:37 +01:00
13 changed files with 8 additions and 8 deletions
--- a/Localization/English/images/OpenShell.png
+++ b/Localization/English/images/OpenShell.png
--- a/README.md
+++ b/README.md
@@ -1,11 +1,11 @@
-## Open-Shell ![Open-Shell](/Src/Setup/OpenShell.ico)
+## Open-Shell <img src=/Src/Setup/OpenShell.ico width="64" />

 *Originally* **[Classic Shell](http://www.classicshell.net)** *by [Ivo Beltchev](https://sourceforge.net/u/ibeltchev/profile/)*

-[![GitHub Release](https://img.shields.io/github/release/Open-Shell/Open-Shell-Menu.svg)](https://github.com/Open-Shell/Open-Shell-Menu/releases/latest) [![GitHub Pre-Release](https://img.shields.io/github/release/Open-Shell/Open-Shell-Menu/all.svg)](https://github.com/Open-Shell/Open-Shell-Menu/releases) [![Build status](https://ci.appveyor.com/api/projects/status/2wj5x5qoypfjj0tr/branch/master?svg=true)](https://ci.appveyor.com/project/passionate-coder/open-shell-menu/branch/master) [![GitQ](https://gitq.com/badge.svg)](https://gitq.com/passionate-coder/Classic-Start) [![Gitter chat](https://badges.gitter.im/gitterHQ/gitter.png)](https://gitter.im/open-shell/Lobby) [![Discord](https://img.shields.io/discord/757701054782636082?color=%4E5D94&label=Discord&logo=discord&logoColor=white)](https://discord.gg/7H6arr5)
+[![GitHub Release](https://img.shields.io/github/release/Open-Shell/Open-Shell-Menu.svg)](https://github.com/Open-Shell/Open-Shell-Menu/releases/latest) [![GitHub Pre-Release](https://img.shields.io/github/release/Open-Shell/Open-Shell-Menu/all.svg)](https://github.com/Open-Shell/Open-Shell-Menu/releases) [![Build status](https://ci.appveyor.com/api/projects/status/2wj5x5qoypfjj0tr/branch/master?svg=true)](https://ci.appveyor.com/project/passionate-coder/open-shell-menu/branch/master) [![GitQ](https://gitq.com/badge.svg)](https://gitq.com/passionate-coder/Classic-Start) [![Gitter chat](https://img.shields.io/gitter/room/badges/shields.svg?color=lightseagreen)](https://gitter.im/open-shell/Lobby) [![Discord](https://img.shields.io/discord/757701054782636082?color=mediumslateblue&label=Discord&logo=discord&logoColor=white)](https://discord.gg/7H6arr5)

-[Home Page](https://open-shell.github.io/Open-Shell-Menu)  
-[Gitter Discussion room](https://gitter.im/Open-Shell)  
+[Homepage](https://open-shell.github.io/Open-Shell-Menu)  
+[Gitter Discussion rooms](https://gitter.im/Open-Shell)  

 ### Features
 - Classic style Start Menu for Windows 7, 8, 8.1, 10
@@ -15,7 +15,7 @@
 - Title bar and status bar for Internet Explorer

 ### Download
-If you just want to use it or looking for setup file, click here to download:
+You can find the latest stable version here:

 [![GitHub All Releases](https://img.shields.io/github/downloads/Open-Shell/Open-Shell-Menu/total?style=for-the-badge)](https://github.com/Open-Shell/Open-Shell-Menu/releases/latest)

@@ -28,6 +28,6 @@ If you just want to use it or looking for setup file, click here to download:
 *For archival reasons, we have a mirror of `www.classicshell.net` [here](https://coddec.github.io/Classic-Shell/www.classicshell.net/).*

 [How To Skin a Start Menu](https://coddec.github.io/Classic-Shell/www.classicshell.net/tutorials/skintutorial.html)  
-[Classic Shell - Custom Start Buttons](https://coddec.github.io/Classic-Shell/www.classicshell.net/tutorials/buttontutorial.html)  
+[Classic Shell: Custom Start Buttons](https://coddec.github.io/Classic-Shell/www.classicshell.net/tutorials/buttontutorial.html)  
 [Questions? Ask on the Discussions section](https://github.com/Open-Shell/Open-Shell-Menu/discussions) or on [Discord](https://discord.gg/7H6arr5)  
-[Report a bug/issue or submit a feature request](https://github.com/Open-Shell/Open-Shell-Menu/issues)
+[Submit a bug report/feature request](https://github.com/Open-Shell/Open-Shell-Menu/issues)
--- a/Src/Localization/Chinese/images/OpenShell.png
+++ b/Src/Localization/Chinese/images/OpenShell.png
--- a/Src/Localization/English/images/OpenShell.png
+++ b/Src/Localization/English/images/OpenShell.png
--- a/Src/Localization/French/images/OpenShell.png
+++ b/Src/Localization/French/images/OpenShell.png
--- a/Src/Localization/Spanish/images/OpenShell.png
+++ b/Src/Localization/Spanish/images/OpenShell.png
--- a/Src/Setup/OpenShell.ico
+++ b/Src/Setup/OpenShell.ico
--- a/Src/Setup/banner.jpg
+++ b/Src/Setup/banner.jpg
--- a/Src/Setup/dialog.jpg
+++ b/Src/Setup/dialog.jpg
--- a/Src/Setup/dialog2.jpg
+++ b/Src/Setup/dialog2.jpg
--- a/Src/Setup/web.ico
+++ b/Src/Setup/web.ico
--- a/Src/StartMenu/StartMenuDLL/MenuCommands.cpp
+++ b/Src/StartMenu/StartMenuDLL/MenuCommands.cpp
@@ -2812,7 +2812,7 @@ void CMenuContainer::ActivateItem( int index, TActivateType type, const POINT *p
 				info.fMask|=CMIC_MASK_NOASYNC; // wait for delete/link commands to finish so we can refresh the menu

 			// we don't want our virtual folder to appear in Explorer's frequent list
-			if (wcsncmp(item.pItemInfo->PATH, L"::{82E749ED-B971-4550-BAF7-06AA2BF7E836}", 40) == 0)
+			if (item.pItemInfo && wcsncmp(item.pItemInfo->PATH, L"::{82E749ED-B971-4550-BAF7-06AA2BF7E836}", 40) == 0)
 				info.fMask &= ~CMIC_MASK_FLAG_LOG_USAGE;

 			s_bPreventClosing=true;
--- a/Src/StartMenu/StartMenuDLL/btn_classic.bmp
+++ b/Src/StartMenu/StartMenuDLL/btn_classic.bmp
Author	SHA1	Message	Date
ge0rdi	b0c1d9a229	Fix for potential crash introduced in `1b013c3` Fixes #1245	2022-12-14 16:10:10 +01:00
Eli Farmer	ac80080f90	Update README.md - General grammar/format/convention improvements - Switch to shields.io for gitter badge and change color of Discord badge	2022-12-08 15:23:34 +01:00
bonzibudd	d28c8e512a	New icons and installer artwork This adds the new artwork for the main icon and installer screens. Addresses #31. Update classic button thumbnail Improve setup banner icon Fix web.ico size New installer art Fix dialog2	2022-12-07 11:58:37 +01:00
bonzibudd	be57a43589	Format ReadMe icon	2022-12-07 11:58:37 +01:00